Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set permissions on TTY. #2508

Merged
merged 1 commit into from
Feb 11, 2019
Merged

Set permissions on TTY. #2508

merged 1 commit into from
Feb 11, 2019

Conversation

russjones
Copy link
Contributor

@russjones russjones commented Jan 18, 2019 •
edited
Loading

Purpose

Set permissions on TTY similar to what OpenSSH does.

Implementation

  • Set permissions of TTY to <user gid>:tty. If the tty group does not exist, fallback to the gid of the user.
  • If the tty group exists, set mode to 0600, othereise 0620.

Related Issues

Fixes #2540

@russjones russjones requested a review from klizhentas January 18, 2019 21:36
klizhentas
klizhentas requested changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@klizhentas klizhentas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change set is missing test.

@russjones russjones merged commit ae2da0a into master Feb 11, 2019
@russjones russjones deleted the rjones/tty-perms branch February 11, 2019 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klizhentas klizhentas klizhentas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@russjones @klizhentas