Merged
Conversation
Some edits I made to the YubiHSM2 docs while going through the test plan. Mostly just adding some extra context and trying to improve readability. Important changes: - added a warning that the YubiHSM2 SDK v 2023.01 is unsupported, due to #25017 - the CA rotation example was out of date because you cannot rotate all CAs at once anymore. Removed the example and I'm just linking to the CA rotation guide now.
github-actions
Bot
requested review from
alexfornuto,
ptgott,
r0mant,
xinding33 and
zmb3
zmb3
approved these changes
Apr 22, 2023
alexfornuto
reviewed
Apr 24, 2023
Co-authored-by: Alex Fornuto <alex.fornuto@goteleport.com>
Closed
alexfornuto
approved these changes
Apr 28, 2023
public-teleport-github-review-bot
Bot
removed request for
ptgott,
r0mant and
xinding33
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
|
@nklaassen See the table below for backport results.
|
This was referenced Apr 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some edits I made to the YubiHSM2 docs while going through the test plan. Mostly just adding some extra context and trying to improve readability.
Important changes: