Skip to content

fix file copy check not happening for agentless SSH connections#25012

Merged
capnspacehook merged 1 commit intomasterfrom
capnspacehook/fix-agentless-file-copy-check
Apr 28, 2023
Merged

fix file copy check not happening for agentless SSH connections#25012
capnspacehook merged 1 commit intomasterfrom
capnspacehook/fix-agentless-file-copy-check

Conversation

@capnspacehook
Copy link
Copy Markdown
Contributor

Fixes #24949.

Copy link
Copy Markdown
Collaborator

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to test this?

Comment thread lib/srv/exec.go Outdated
@zmb3
Copy link
Copy Markdown
Collaborator

zmb3 commented Apr 21, 2023

Why is this going directly to branch/v13? Where is the master PR?

@capnspacehook
Copy link
Copy Markdown
Contributor Author

Re: merging into v13 directly, my bad it's been a long week lol I'll fix that.

Re: testing, I thought about that for awhile, not sure what to do here tbh. There are already tests asserting that lib/srv.ServerContext.CheckSFTPAllowed and friends work properly, but not sure how to test the rest without adding another integration test.

@capnspacehook capnspacehook force-pushed the capnspacehook/fix-agentless-file-copy-check branch from 0d0b8e5 to e56db63 Compare April 21, 2023 22:57
@capnspacehook capnspacehook changed the base branch from branch/v13 to master April 21, 2023 22:57
@capnspacehook
Copy link
Copy Markdown
Contributor Author

Going to close and reopen to hopefully fix CI checks not starting

@capnspacehook capnspacehook reopened this Apr 24, 2023
@capnspacehook capnspacehook force-pushed the capnspacehook/fix-agentless-file-copy-check branch from e56db63 to 065b08e Compare April 24, 2023 15:01
@capnspacehook capnspacehook requested a review from zmb3 April 24, 2023 15:51
@capnspacehook capnspacehook force-pushed the capnspacehook/fix-agentless-file-copy-check branch 2 times, most recently from fc8fb16 to f102d64 Compare April 24, 2023 20:19
Comment thread lib/srv/exec.go Outdated
@capnspacehook capnspacehook force-pushed the capnspacehook/fix-agentless-file-copy-check branch 2 times, most recently from e381afc to 5fab7f9 Compare April 26, 2023 19:43
@capnspacehook capnspacehook force-pushed the capnspacehook/fix-agentless-file-copy-check branch 2 times, most recently from 4020a2f to be86de2 Compare April 28, 2023 18:56
@capnspacehook capnspacehook force-pushed the capnspacehook/fix-agentless-file-copy-check branch from be86de2 to 52f8b6e Compare April 28, 2023 19:00
@capnspacehook capnspacehook enabled auto-merge April 28, 2023 19:13
@capnspacehook capnspacehook added this pull request to the merge queue Apr 28, 2023
Merged via the queue into master with commit 506f537 Apr 28, 2023
@capnspacehook capnspacehook deleted the capnspacehook/fix-agentless-file-copy-check branch April 28, 2023 19:32
@public-teleport-github-review-bot
Copy link
Copy Markdown

@capnspacehook See the table below for backport results.

Branch Result
branch/v13 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scp to agentless nodes allowed in spite of RBAC denial

4 participants