athena audit logs - delete from sqs#24967
Merged
tobiaszheller merged 2 commits intomasterfrom Apr 25, 2023
Merged
Conversation
github-actions
Bot
added
audit-log
mdwn
approved these changes
Apr 24, 2023
tobiaszheller
force-pushed
the
tobiaszheller/auditevents-athena-sqs-parquets3
branch
3 times, most recently
from
76deca5 to
c052d8b
Compare
tobiaszheller
force-pushed
the
tobiaszheller/auditevents-athena-delete-from-sqs
branch
from
68c6d23 to
8a8727b
Compare
Base automatically changed from
tobiaszheller/auditevents-athena-sqs-parquets3
to
master
April 25, 2023 12:19
tobiaszheller
force-pushed
the
tobiaszheller/auditevents-athena-delete-from-sqs
branch
from
8a8727b to
97c8945
Compare
rosstimothy
reviewed
Apr 25, 2023
rosstimothy
approved these changes
Apr 25, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from nklaassen
tobiaszheller
deleted the
tobiaszheller/auditevents-athena-delete-from-sqs
branch
|
@tobiaszheller See the table below for backport results.
|
|
@tobiaszheller See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/gravitational/teleport.e/issues/894
RFD: https://github.com/gravitational/teleport/blob/master/rfd/0118-scalable-audit-logs.md
This PR add to athena audit log, delete from sqs aka "acknowledge".
Delete it done when parquet file was successfull written to s3.
If error is returned from delete, it means that we will retry those "NACK" messages in next batch, or they will go to dead-letter queue after couple of NACKs.