ensure forwarded SSH agent is always closed#24947
Merged
capnspacehook merged 1 commit intomasterfrom Apr 21, 2023
Merged
Conversation
capnspacehook
added
OpenSSH
zmb3
reviewed
Apr 20, 2023
Previously when handling an SSH agent forward request from a SSH connection to a registered SSH node, the forwarding SSH server would open a SSH channel for the SSH agent but never close it. tsh wasn't affected by this and would exit cleanly when the SSH session was closed. OpenSSH ssh would hang waiting for the open SSH agent channel to close, which would never happen.
capnspacehook
force-pushed
the
capnspacehook/fix-agentless-agent-hang
branch
from
75ac350 to
825b531
Compare
smallinsky
approved these changes
Apr 21, 2023
zmb3
approved these changes
Apr 21, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from marcoandredinis
|
@capnspacehook See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously when handling an SSH agent forward request from a SSH connection to a registered SSH node, the forwarding SSH server would open a SSH channel for the SSH agent but never close it. tsh wasn't affected by this and would exit cleanly when the SSH session was closed. OpenSSH ssh would hang waiting for the open SSH agent channel to close, which would never happen.
Fixes #24936.