Document HA for Access Request plugins#24945
Merged
Conversation
alexfornuto
approved these changes
Apr 21, 2023
Contributor
alexfornuto
left a comment
alexfornuto
left a comment
There was a problem hiding this comment.
I made some suggestions to reduce verbosity, otherwise 👍.
Comment on lines
+32
to
+35
| You can run multiple instances of an Access Request plugin for high | ||
| availability. To do so, run each instance in a separate availability zone. There | ||
| is no need for additional configuration or load balancing, as plugins avoid | ||
| creating duplicate requests to their third-party APIs. |
Contributor
There was a problem hiding this comment.
Tightening:
Suggested change
| You can run multiple instances of an Access Request plugin for high | |
| availability. To do so, run each instance in a separate availability zone. There | |
| is no need for additional configuration or load balancing, as plugins avoid | |
| creating duplicate requests to their third-party APIs. | |
| By running multiple instances of an Access Request plugin in separate availability | |
| zones, you can achieve high availability. Plugins avoid creating duplicate requests | |
| to third-party APIs, so no load balancing is required. |
Contributor
Author
There was a problem hiding this comment.
I've suggested:
You can run multiple instances of an Access Request plugin for high availability
by deploying each instance in a separate availability zone. There is no need for
additional configuration or load balancing, as plugins avoid creating duplicate
requests to their third-party APIs.In the sentence, "By running multiple instances of an Access Request plugin in separate availability
zones, you can achieve high availability," I think putting "you can achieve high availability" at the end of the sentence makes it less clear, since we have to get to the end to know what the sentence is about.
Closes #8970 Add an "Architecture" section to the Access Request plugin index page that describes how Access Request plugins run, including what an HA setup looks like.
ptgott
force-pushed
the
paul.gottschling/8970-plugin-ha
branch
from
408380e to
faa9a82
Compare
stevenGravy
reviewed
May 2, 2023
stevenGravy
reviewed
May 2, 2023
stevenGravy
reviewed
May 2, 2023
stevenGravy
approved these changes
May 2, 2023
This was referenced May 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8970
Add an "Architecture" section to the Access Request plugin index page that describes how Access Request plugins run, including what an HA setup looks like.