Change Helm reference --set formatting#24944
Merged
Conversation
github-actions
Bot
requested review from
alexfornuto,
r0mant,
xinding33 and
zmb3
alexfornuto
approved these changes
Apr 21, 2023
Closes #9686 Since the `--set` flag examples aren't commands, this change removes the shell prompts and changes code fence labels from `code` to `text`.
ptgott
force-pushed
the
paul.gottschling/9686-set
branch
from
582fb68 to
b1b3ffb
Compare
Contributor
|
Could we just drop them? This |
Keep the values.yaml examples. Used the following script to generate the
change:
files="$(find docs/pages/reference/helm-reference -name "*.mdx")";
for i in $(echo "$files"); do
tmp=$(awk 'BEGIN{yaml=""}
/<Tabs>/{t=1}
t==1 && /```yaml/{y=1; yaml="`values.yaml` example:\n\n"}
y==1{yaml = (yaml "\n" $0)}
y==1 && /```$/{y=0; print yaml; yaml=""}
t==1 && /<\/Tabs/{t=0; next}
t==0{print $0 }' $i)
echo "$tmp" > $i;
done
Contributor
Author
|
@hugoShaka Sounds good! I've made the change in 3a7472a |
public-teleport-github-review-bot
Bot
removed request for
r0mant,
xinding33 and
zmb3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9686
Since the
--setflag examples aren't commands, this change removes the shell prompts and changes code fence labels fromcodetotext.