don't rely on info in SSH user cert when connecting to agentless nodes#24935
Merged
capnspacehook merged 1 commit intomasterfrom Apr 21, 2023
Merged
don't rely on info in SSH user cert when connecting to agentless nodes#24935capnspacehook merged 1 commit intomasterfrom
capnspacehook merged 1 commit intomasterfrom
Conversation
After finding now 2 very similar bugs today related to trying to pull connection information out of SSH certificates instead of just passing it directly, opt to pass the information directly to prevent future bugs.
zmb3
approved these changes
Apr 20, 2023
AntonAM
approved these changes
Apr 20, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from codingllama
|
@capnspacehook See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After finding now 2 very similar bugs today related to trying to pull connection information out of SSH certificates instead of just passing it directly, opt to pass the information directly to prevent future bugs.
Fixes #24922.