[v12] Integrations: AWS OIDC - ListDatabases action#24877
Merged
marcoandredinis merged 1 commit intobranch/v12from Apr 28, 2023
Merged
[v12] Integrations: AWS OIDC - ListDatabases action#24877marcoandredinis merged 1 commit intobranch/v12from
marcoandredinis merged 1 commit intobranch/v12from
Conversation
|
@marcoandredinis - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
marcoandredinis
force-pushed
the
marco/v12/backport24460
branch
from
102d101 to
a74d423
Compare
marcoandredinis
force-pushed
the
marco/v12/backport24460
branch
4 times, most recently
from
52f1f3d to
ec35491
Compare
This PR adds a new Action for the AWSOIDC Integration: ListDatabases
The goal of this action is to provide the User a list of RDS Databases
from which the User will pick one to be added as a Teleport Database
Resource.
This way, the user doesn't need to copy/paste DB name, endpoints and
labels.
Before being able to call this action, the User has to set up an AWS
OIDC integration.
How does it work:
```
Client (web app)
│ ▲
│ │4. Returns list of DBs
1. List Databases │ │ (name, tags, status, endpoint)
│ │
│ │
│ │
│ │
▼ │ 3. rds.DescribeDBInstances
┌───────────┴────┐ (auth: token) ┌─────────┐
│ ├─────────────────────────────────►│ │
│ Teleport Proxy │ │ AWS │
│ │ 3.1. Get OIDC Config │ │
│ │◄─────────────────────────────────┤ │
│ │ 3.2. Get RSA Public Key │ │
│ │◄─────────────────────────────────┤ ├─────────┐ 3.3.
│ │ │ │ │Validates token signature
│ │ │ │ │with received public key
│ │ 3.4 Returns list of DBs │ │◄────────┘
│ │◄─────────────────────────────────┤ │
└─┬──────────────┘ └─────────┘
│
│ 2. Sign Token
│
▼
┌───────────────────┐
│ │
│ Teleport Auth │
│ RSA Private Key │
└───────────────────┘
```
Eg of an HTTP response from `4.`
```json
{
"databases":[
{
"name":"marcodb-test",
"desc":"RDS instance in us-east-1",
"protocol":"postgres",
"type":"rds",
"labels":[
{
"name":"account-id",
"value":"123456789012"
},
{
"name":"canBeDeleted",
"value":"yes"
},
{
"name":"endpoint-type",
"value":"instance"
},
{
"name":"engine",
"value":"postgres"
},
{
"name":"engine-version",
"value":"14.6"
},
{
"name":"env",
"value":"test"
},
{
"name":"project",
"value":"discover"
},
{
"name":"region",
"value":"us-east-1"
},
{
"name":"status",
"value":"available"
},
{
"name":"teleport.dev/origin",
"value":"cloud"
}
],
"hostname":"marcodb-test.abcdef123456.us-east-1.rds.amazonaws.com",
"uri":"marcodb-test.abcdef123456.us-east-1.rds.amazonaws.com:5432",
"aws":{
"region":"us-east-1",
"rds":{
"instance_id":"marcodb-test",
"resource_id":"db-123456ABCEDF123456ABCEDF00",
"iam_auth":false
},
"account_id":"123456789012",
"status":"available"
}
}
]
}
```
marcoandredinis
force-pushed
the
marco/v12/backport24460
branch
from
ec35491 to
974541f
Compare
Contributor
Author
r0mant
approved these changes
Apr 28, 2023
kimlisa
approved these changes
Apr 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #24460