[v13] refactor how 'tsh scp' destinations are parsed#24860
Merged
capnspacehook merged 1 commit intobranch/v13from Apr 20, 2023
Merged
[v13] refactor how 'tsh scp' destinations are parsed#24860capnspacehook merged 1 commit intobranch/v13from
capnspacehook merged 1 commit intobranch/v13from
Conversation
A complex regex was previously used to parse 'tsh scp' destinations, which was hard to understand and even harder to maintain for those not intimately familiar with regex, despite it being heavily commented. Instead parse destinations directly and add more test cases and a fuzz test to ensure parsing won't panic and the new parse function doesn't have any regressions.
github-actions
Bot
requested review from
jentfoo,
lxea,
r0mant,
russjones and
timothyb89
r0mant
approved these changes
Apr 19, 2023
timothyb89
approved these changes
Apr 19, 2023
public-teleport-github-review-bot
Bot
removed request for
jentfoo,
lxea and
russjones
jentfoo
approved these changes
Apr 20, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #24441 to branch/v13.