Skip to content

Log informative messages for device authn failures#24849

Merged
codingllama merged 1 commit intomasterfrom
codingllama/dt-tsh-tooeager
Apr 20, 2023
Merged

Log informative messages for device authn failures#24849
codingllama merged 1 commit intomasterfrom
codingllama/dt-tsh-tooeager

Conversation

@codingllama
Copy link
Copy Markdown
Contributor

Log brief, informative messages for commonplace device authn failures like "device key not found" or "platform not supported".

Addresses #23776, related to https://github.com/gravitational/teleport.e/issues/826.

@codingllama codingllama requested a review from strideynet April 19, 2023 20:36
@github-actions github-actions Bot requested review from lxea and ravicious April 19, 2023 20:36
@codingllama
Copy link
Copy Markdown
Contributor Author

For sure conflicts with #24752, I'll fix it on whatever lands last.

I decided against the explicit version checks I had in mind for #23776, as I got concerned about ping versions (although in practice they seem fine). We do handle "unimplemented" relatively well now, so it also seemed enough.

@codingllama codingllama added this pull request to the merge queue Apr 20, 2023
Merged via the queue into master with commit 8dd586b Apr 20, 2023
@codingllama codingllama deleted the codingllama/dt-tsh-tooeager branch April 20, 2023 14:04
@public-teleport-github-review-bot
Copy link
Copy Markdown

@codingllama See the table below for backport results.

Branch Result
branch/v12 Create PR
branch/v13 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants