Skip to content

Add auto-enroll toggle to device trust config#24747

Merged
codingllama merged 5 commits intomasterfrom
codingllama/dt-mdm-config
Apr 20, 2023
Merged

Add auto-enroll toggle to device trust config#24747
codingllama merged 5 commits intomasterfrom
codingllama/dt-mdm-config

Conversation

@codingllama
Copy link
Copy Markdown
Contributor

Add the auto-enroll toggle to both proto and YAML-based configs.

https://github.com/gravitational/teleport.e/issues/826

@codingllama
Copy link
Copy Markdown
Contributor Author

Not strictly required for 13.0, despite the backport label. I'll be necessary for 13.1, but I might delay the backport for now (unless it starts getting in the way).

@codingllama codingllama force-pushed the codingllama/dt-mdm-config branch from aef7f0a to 1f0ffd9 Compare April 18, 2023 18:02
@codingllama codingllama force-pushed the codingllama/dt-mdm-config branch 2 times, most recently from 6bd6084 to ee9f9f0 Compare April 18, 2023 18:55
@codingllama
Copy link
Copy Markdown
Contributor Author

Friendly ping @strideynet @ibeckermayer ?

1 similar comment
@codingllama
Copy link
Copy Markdown
Contributor Author

Friendly ping @strideynet @ibeckermayer ?

Copy link
Copy Markdown
Contributor

@ibeckermayer ibeckermayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could add a test checking that it's set to false if not defined to be exhaustive.

@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from strideynet April 20, 2023 18:31
@codingllama codingllama force-pushed the codingllama/dt-mdm-config branch from ee9f9f0 to 53754a0 Compare April 20, 2023 18:40
@codingllama
Copy link
Copy Markdown
Contributor Author

You could add a test checking that it's set to false if not defined to be exhaustive.

Done: 53754a0.

@codingllama codingllama force-pushed the codingllama/dt-mdm-config branch from 53754a0 to 91af21a Compare April 20, 2023 18:53
@codingllama codingllama enabled auto-merge April 20, 2023 18:54
@codingllama codingllama added this pull request to the merge queue Apr 20, 2023
Merged via the queue into master with commit dd20892 Apr 20, 2023
@codingllama codingllama deleted the codingllama/dt-mdm-config branch April 20, 2023 19:37
@public-teleport-github-review-bot
Copy link
Copy Markdown

@codingllama See the table below for backport results.

Branch Result
branch/v13 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants