Skip to content

Fixes for teleport-kube-agent-updater#24746

Merged
hugoShaka merged 7 commits intomasterfrom
hugo/fix-updater-chart-selectors
Apr 20, 2023
Merged

Fixes for teleport-kube-agent-updater#24746
hugoShaka merged 7 commits intomasterfrom
hugo/fix-updater-chart-selectors

Conversation

@hugoShaka
Copy link
Copy Markdown
Contributor

@hugoShaka hugoShaka commented Apr 18, 2023

Fixes issues detected during test-plan:

  • teleport-kube-agent chart updater deployment had an invalid selector and flags
  • teleport-kube-agent-updater was not statically built on linux/amd64
  • the updater was lacking a bunch of RBAC rules to perform leader election, watch secrets, and send events
  • the updater was answering 404 to its healthz and ready routes

@hugoShaka hugoShaka added test-plan-problem Issues which have been surfaced by running the manual release test plan backport/branch/v13 labels Apr 18, 2023
@hugoShaka hugoShaka marked this pull request as ready for review April 18, 2023 20:27
@github-actions github-actions Bot requested a review from ryanclark April 18, 2023 20:28
@hugoShaka hugoShaka mentioned this pull request Apr 18, 2023
23 tasks
@marcoandredinis
Copy link
Copy Markdown
Contributor

I would just update the PR title 😅

@hugoShaka hugoShaka changed the title Hugo/fix updater chart selectors Fixes for teleport-kube-agent-updater Apr 20, 2023
@hugoShaka hugoShaka added this pull request to the merge queue Apr 20, 2023
Merged via the queue into master with commit 68bf10d Apr 20, 2023
@hugoShaka hugoShaka deleted the hugo/fix-updater-chart-selectors branch April 20, 2023 13:32
@public-teleport-github-review-bot
Copy link
Copy Markdown

@hugoShaka See the table below for backport results.

Branch Result
branch/v13 Failed

hugoShaka added a commit that referenced this pull request Apr 22, 2023
* integrations/updater: disable CGO to ensure static builds

* helm: fix updater selectors in `teleport-kube-agent`

* helm: fix updater flags

* helm: make the updater able to watch secrets, create events and acquire leases

* integrations/updater: add dummy healthz route

* integrations/updater: fix typo in DEBUG instructions

* helm: update test snapshots
webvictim pushed a commit that referenced this pull request Apr 24, 2023
* integrations/updater: disable CGO to ensure static builds

* helm: fix updater selectors in `teleport-kube-agent`

* helm: fix updater flags

* helm: make the updater able to watch secrets, create events and acquire leases

* integrations/updater: add dummy healthz route

* integrations/updater: fix typo in DEBUG instructions

* helm: update test snapshots
@r0mant r0mant mentioned this pull request Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

helm size/sm test-plan-problem Issues which have been surfaced by running the manual release test plan

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants