Use CompareAndSwap for OktaAssignments instead of lock.#24727
Merged
Conversation
CompareAndSwap should be used for the OktaAssignment updates instead of a lock, as it's lighter wait and fits the intended problem better.
espadolini
approved these changes
Apr 18, 2023
| var previousAssignment types.OktaAssignment | ||
| err := o.assignmentSvc.UpdateAndSwapResource(ctx, name, func(assignment types.OktaAssignment) error { | ||
| previousAssignment = assignment.Copy() | ||
| for _, action := range assignment.GetActions() { |
Contributor
There was a problem hiding this comment.
Does GetActions return a mutable slice, or do we need to then do an assignment.SetActions after modifying the actions' statuses?
Same goes for UpdateOktaAssignment.
Contributor
Author
There was a problem hiding this comment.
It does return a mutable slice.
avatus
approved these changes
Apr 18, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from jakule
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This was referenced Apr 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CompareAndSwap should be used for the OktaAssignment updates instead of a lock, as it's lighter wait and fits the intended problem better.