[v13] Prevent multiple discovery agents to race against each other#24715
Merged
tigrato merged 1 commit intobranch/v13from Apr 18, 2023
Merged
[v13] Prevent multiple discovery agents to race against each other#24715tigrato merged 1 commit intobranch/v13from
tigrato merged 1 commit intobranch/v13from
Conversation
Currently, when multiple discovery services are running with different selectors, they will race against each other and delete the other resources. This PR fixes that behavior if the databases or kube clusters existent in auth do not match the current selectors, they will be ignored. This has a slight problem when a user stops a discovery agent, he must manually delete the resources created, otherwise they will be available forever. Fixes #23699
github-actions
Bot
added
backport
database-access
github-actions
Bot
requested review from
fspmarshall,
greedy52,
r0mant and
smallinsky
smallinsky
approved these changes
Apr 18, 2023
r0mant
approved these changes
Apr 18, 2023
public-teleport-github-review-bot
Bot
removed request for
fspmarshall and
greedy52
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #24214 to branch/v13