Merged
Conversation
r0mant
approved these changes
Apr 18, 2023
Collaborator
r0mant
left a comment
r0mant
left a comment
There was a problem hiding this comment.
@hugoShaka You now unfortunately need to backport this to branch/v13 as it's already been cut.
tcsc
approved these changes
Apr 18, 2023
Contributor
tcsc
left a comment
tcsc
left a comment
There was a problem hiding this comment.
One question - are the references to 12.2.1 for a rollback or something? If so, is it worth leaving these as the old image just in case?
public-teleport-github-review-bot
Bot
removed request for
marcoandredinis and
probakowski
Contributor
Author
It's an arbitrary version different from the default one to test the override. I did not want to have distroless v8 examples as the image doesn't exist, so I updated to an existing version. |
|
@hugoShaka See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes Helm default to distroless images.
This can be reverted by setting
imageorenterpriseImage.I'll send a separate docs PR tomorrow because we want to merge this quickly and bundling the docs changes would likely mean bypassing the docs folks.
I have not tested the change, in theory, images are supposed to behave the same way but we might find surprises during the v13 test plan. Especially some docs might be asking users to run
bashfor example.