Merged
Conversation
github-actions
Bot
added
size/sm
tsh
rosstimothy
approved these changes
Apr 17, 2023
public-teleport-github-review-bot
Bot
removed request for
rudream and
smallinsky
Contributor
Author
|
@zmb3 I added a test, let me know what you think. @rosstimothy maybe you can reuse / add to this test for #24701 |
rosstimothy
approved these changes
Apr 18, 2023
rosstimothy
reviewed
Apr 18, 2023
Joerger
force-pushed
the
joerger/headless-explicit-username
branch
from
0068b19 to
fe9a190
Compare
Joerger
force-pushed
the
joerger/headless-explicit-username
branch
from
aab169f to
69ffe5d
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Joerger
added a commit
that referenced
this pull request
Apr 24, 2023
* Return an error if user is not explicity set for headless login. * Add test. * Resolve comments. * Fix typo.
Joerger
added a commit
that referenced
this pull request
Apr 24, 2023
* Return an error if user is not explicity set for headless login. * Add test. * Resolve comments. * Fix typo.
This was referenced Apr 24, 2023
Joerger
added a commit
that referenced
this pull request
Apr 25, 2023
Joerger
added a commit
that referenced
this pull request
Apr 25, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return an error if user is not explicitly set for headless login. This should help prevent users from hitting #23436 due to their OS user being used for login by default.