docs: make consistent access request plugins helm configuration and instructions#24654
Merged
stevenGravy merged 5 commits intomasterfrom Apr 18, 2023
Merged
docs: make consistent access request plugins helm configuration and instructions#24654stevenGravy merged 5 commits intomasterfrom
stevenGravy merged 5 commits intomasterfrom
Conversation
Contributor
stevenGravy
commented
Apr 16, 2023
stevenGravy
commented
- use proxy address as address example in config matching doc instrs
- use same language for cloud and self-hosted address as executable instructions.
github-actions
Bot
requested review from
alexfornuto,
klizhentas,
ptgott,
r0mant,
xinding33 and
zmb3
zmb3
approved these changes
Apr 17, 2023
Collaborator
zmb3
left a comment
zmb3
left a comment
There was a problem hiding this comment.
The change looks fine, though the commit message is pretty hard to understand.
ptgott
reviewed
Apr 18, 2023
ptgott
approved these changes
Apr 18, 2023
Contributor
ptgott
left a comment
ptgott
left a comment
There was a problem hiding this comment.
Approved with one suggestion to address my feedback from earlier
public-teleport-github-review-bot
Bot
removed request for
alexfornuto,
klizhentas,
r0mant and
xinding33
|
@stevenGravy See the table below for backport results.
|
This was referenced Apr 18, 2023
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.