don't delete unit schedule file#24631
Merged
fspmarshall merged 3 commits intomasterfrom May 9, 2023
Merged
Conversation
hugoShaka
approved these changes
Apr 14, 2023
rosstimothy
approved these changes
Apr 15, 2023
public-teleport-github-review-bot
Bot
removed request for
ibeckermayer and
jakule
zmb3
approved these changes
Apr 15, 2023
|
@fspmarshall See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the unit schedule exporter to blank the upgrade schedule file instead of deleting it when unhealthy. This change is intended to preserve the file permissions of the schedule file across resets so that users running teleport as a non-root user can choose to grant it the ability to modify the schedule file without also granting said user the ability to modify other upgrader parameters (e.g.
endpoint).This PR also slightly loosens the default file permissions so that non-root users can view (but still not edit) the upgrader parameters. This is safe because the upgrader parameters never contain any secret values.