Adds dependencies for teleport.e #1135#24574
Merged
michellescripts merged 1 commit intomasterfrom Apr 21, 2023
Merged
Conversation
michellescripts
force-pushed
the
michelle/team-banner
branch
2 times, most recently
from
ee2fa37 to
0af860b
Compare
ibeckermayer
approved these changes
Apr 17, 2023
mcbattirola
approved these changes
Apr 18, 2023
- Adds helper methods for formatting dates - Adds stripe dependencies to yarn lock
michellescripts
force-pushed
the
michelle/team-banner
branch
from
0af860b to
97da51a
Compare
timothyb89
approved these changes
Apr 21, 2023
| } | ||
| return format(date, cfg.shortFormat); | ||
| } catch (err) { | ||
| logger.error('displayDate()', err); |
Contributor
There was a problem hiding this comment.
maybe a nitpick, but this log message might be misleading?
Suggested change
| logger.error('displayDate()', err); | |
| logger.error('displayShortDate()', err); |
public-teleport-github-review-bot
Bot
removed the request for review
from ryanclark
michellescripts
added a commit
that referenced
this pull request
Apr 26, 2023
michellescripts
added a commit
that referenced
this pull request
Apr 26, 2023
michellescripts
added a commit
that referenced
this pull request
May 3, 2023
michellescripts
added a commit
that referenced
this pull request
May 3, 2023
This was referenced May 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports: https://github.com/gravitational/cloud/issues/3536
Teleport.e counterpart: https://github.com/gravitational/teleport.e/pull/1135