Discover: Add new usage reporting events#24567
Merged
Conversation
kimlisa
force-pushed
the
lisa/add-new-events
branch
from
dabdfb1 to
a88ffee
Compare
avatus
approved these changes
Apr 13, 2023
marcoandredinis
approved these changes
Apr 14, 2023
Contributor
marcoandredinis
left a comment
marcoandredinis
left a comment
There was a problem hiding this comment.
LGTM
I would just change the event to include the Integration term and its name (AWS OIDC)
Or instead of adding its name as part of the event, add it as a property.
kimlisa
force-pushed
the
lisa/add-new-events
branch
from
4221c35 to
31fd1f3
Compare
ryanclark
approved these changes
Apr 14, 2023
kimlisa
added a commit
that referenced
this pull request
May 2, 2023
* Add aws connect account and enroll rds dbs event * Update FE types to reflect backend changes * Rename * Add missing convert usager
kimlisa
added a commit
that referenced
this pull request
May 3, 2023
* Discover: Add more database type event names (#23742) * Add unguided database event names * Add database doc event names * Discover: Add new usage reporting events (#24567) * Add aws connect account and enroll rds dbs event * Update FE types to reflect backend changes * Rename * Add missing convert usager
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #22130
Cloud PR (merge first): https://github.com/gravitational/cloud/pull/4151
Need new usage events for the two new screens for the web UI discover flow for the AWS RDS (pictured below):
I basically just tried to copy and paste existing work and only thing changing is the event name. Please advice on better naming.
Note on the RDS database screen, i think we have plans for user to select
multiple rds dbsbut phase 1 is just selecting one (but i included theselectedResourcesCountanyways for the future)