Fetch groups for GSuite SSO. #2456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kontsevoy @russjones please review the PR and the referenced ticket - it includes documentation base too. |
|
The code looks fine to me as always. Can we please make sure that the reference ticket won't get auto-closed when you mege? It needs to stay open with 'documentation' label. |
kontsevoy
approved these changes
Dec 26, 2018
|
@kontsevoy sure, that's the plan |
|
@russjones ping |
russjones
approved these changes
Jan 7, 2019
lib/auth/oidc.go
Outdated
| for { | ||
| if count > MaxPages { | ||
| warningMessage := "Truncating list of teams used to populate claims: " + | ||
| "hit maximum number pages that can be fetched from GitHub." |
There was a problem hiding this comment.
"hit maximum number pages that can be fetched from GSuite."
| count := 0 | ||
| var groups []string | ||
| var nextPageToken string | ||
| collect: |
There was a problem hiding this comment.
I'd break this out into it's own function, seems like a lot packed into a single function.
klizhentas
force-pushed
the
sasha/gsuite
branch
from
4d7cf56 to
8867468
Compare
Fixes #2455 This commit adds support for fetching groups for GSuite SSO logins via OIDC connector interface. If OIDC connector has a special scope: `https://www.googleapis.com/auth/admin.directory.group.readonly` teleport will fetch user's group membership and populate groups claim.
klizhentas
force-pushed
the
sasha/gsuite
branch
from
8867468 to
bfbeb24
Compare
klizhentas
added a commit
that referenced
this pull request
Jan 17, 2019
Fixes #2455 This commit adds support for fetching groups for GSuite SSO logins via OIDC connector interface. If OIDC connector has a special scope: `https://www.googleapis.com/auth/admin.directory.group.readonly` teleport will fetch user's group membership and populate groups claim.
klizhentas
added a commit
that referenced
this pull request
Jan 17, 2019
* Fetch groups for GSuite SSO. (#2456) Fixes #2455 This commit adds support for fetching groups for GSuite SSO logins via OIDC connector interface. If OIDC connector has a special scope: `https://www.googleapis.com/auth/admin.directory.group.readonly` teleport will fetch user's group membership and populate groups claim. * Pass kubernetes groups to the remote cluster. (#2484) This commit allows remote cluster to reference the kubernetes groups coming from the roles of the main cluster in the trusted clusters configuration. For example, main cluster can have a user with a role 'main' and kubernetes groups: kube_groups: ['system:masters'] and SSH logins: logins: ['root'] Remote cluster can choose to map this 'main' cluster to it's own: 'remote-admin' cluster in the trusted cluster config: role_map: - remote: 'main' local: 'remote-admin' The role 'remote-admin' of the remote cluster can now be templated to use the main cluster role main logins and kubernetes_groups using variables: logins: ['{{internal.logins}}'] kubernetes_groups: ['{{internal.kubernetes_groups}}'] This is possible because teleport now encodes both values in X509 certificate metadata and remote cluster passes these values as 'internal' traits to the template engine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2455
This commit adds support for fetching
groups for GSuite SSO logins via
OIDC connector interface.
If OIDC connector has a special scope:
https://www.googleapis.com/auth/admin.directory.group.readonlyteleport will fetch user's group membership and populate
groups claim.