Conversation
avatus
force-pushed
the
michaelmyers/add_file_transfer_request_event
branch
from
ba33ff2 to
0b917bb
Compare
There was a problem hiding this comment.
| string RequestID = 3 [(gogoproto.jsontag) = "requestId"]; | |
| string RequestID = 3 [(gogoproto.jsontag) = "requestID"]; |
There was a problem hiding this comment.
Sweet, idk why i didn't think of this. great idea!
There was a problem hiding this comment.
Don't we want to include the user metadata?
There was a problem hiding this comment.
We can but I don't see it being necessary at this point. The process doesn't really "care" who did it, as the approvers are stored in the request, as well as broadcasted (in the future PR) to the shared session on each action. This is mostly just an event to notify an updated happened to the state of the event.
smallinsky
left a comment
smallinsky
left a comment
There was a problem hiding this comment.
I haven't caught up the full context of the RFD but per this protobuf change LGTM.
There was a problem hiding this comment.
nit: Could you updated the comment and describe the the context of direction
avatus
force-pushed
the
michaelmyers/add_file_transfer_request_event
branch
2 times, most recently
from
c93a185 to
64ebb29
Compare
avatus
force-pushed
the
michaelmyers/add_file_transfer_request_event
branch
from
64ebb29 to
d1dc225
Compare
3 participants
Supports: #23546
This PR only adds a single event, but the proto changes were quite substantial so I'm breaking this chunk out to clean up the next, larger PRs