-
Notifications
You must be signed in to change notification settings - Fork 2.1k
docs: update docker guide to allow for server access and show troubleshooting #24549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9b198f8
docs: update docker guide to allow for server access and show trouble…
stevenGravy 083b1e9
Apply suggestions from code review
stevenGravy d162b68
formatting
93d903b
Updates including providing info on distroless, usage change
stevenGravy 5549aa6
format length
stevenGravy 3fd31b5
Merge branch 'master' into stevenGravy/docs/dockerguide
stevenGravy 08a2c1c
Lint fix
stevenGravy 92453bc
verbiage update
stevenGravy 3f2d1b2
verbiage update
stevenGravy 7eb4b28
verbiage update
stevenGravy 57a399b
Merge branch 'master' into stevenGravy/docs/dockerguide
stevenGravy f3c1ee2
Merge branch 'master' into stevenGravy/docs/dockerguide
stevenGravy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to use the home directory here? This might be unexpected for a user who wants to create their own project directory for this demo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how we've had it for quite a while. This lets them spin it up in a user account dir vs requiring
sudochecks an things. I would leave it as is.