Merged
Conversation
ravicious
approved these changes
Apr 17, 2023
Member
ravicious
left a comment
ravicious
left a comment
There was a problem hiding this comment.
It could use some media queries on wider screens but I'm not even sure how to add them with styled-components.
In any case, this feels better than what we have right now!
| min-height: 100px; | ||
| max-height: 80%; | ||
| height: 100%; | ||
|
|
Member
There was a problem hiding this comment.
There are some unnecessary spaces on this line which are not caught by either Prettier or ESLint.
kimlisa
approved these changes
Apr 18, 2023
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This was referenced Apr 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The audit log details dialog is a modal that shows the JSON representation of an event, which tends to be pretty large. With this change, we will make use of a bigger percentage of screen real estate.