Update docs related to the search bar#24515
Conversation
ravicious
left a comment
ravicious
left a comment
There was a problem hiding this comment.
We have to sort out the more options menu situation which will probably require more changes in the doc, but the rest of the proposed changes looks good.
| Trusted Clusters and there are leaf clusters connected to the root cluster. It lets you browse | ||
| leaf cluster resources. It also changes which cluster the commands in the command bar are going to target. | ||
| leaf cluster resources. | ||
| - The **more options menu** (to the left of the profile selector), containing options such as |
There was a problem hiding this comment.
idk, I feel like we cannot refer to it as "the more options menu" because it looks terrible in text. For example, when talking about the cluster selector I'd like to add this text:
It also changes which cluster the local terminal tabs opened through "Open new terminal" from the more options menu are going to be bound to.
I searched through some old Apple docs, e.g. https://web.archive.org/web/20150818000225/https://support.apple.com/en-us/HT204839, and it looks like in their UI the More Options icon is always referred to in the context of another specific part of the UI.
FWIW, these are not options, each item refers to an action. But even if we call it "more actions" then "more actions menu" still looks bad.
What about renaming it to something like "additional actions menu"? Instead of saying "click the More Options icon" we'd say "open the additional actions menu" and then the user can refer to this section of the docs to understand what the "additional actions menu" is.
There was a problem hiding this comment.
I don't have a strong opinion on it, but I think this rename makes sense 👍
| - The **search bar** (in the middle), which allows you to search for resources across clusters. | ||
| - The **cluster selector** (to the left of the search bar), which shows up only if you have set up | ||
| Trusted Clusters and there are leaf clusters connected to the root cluster. It lets you browse | ||
| leaf cluster resources. It also changes which cluster the commands in the command bar are going to target. |
There was a problem hiding this comment.
Let's keep this:
Also, the "Open new terminal" action will bound new terminal tabs to the selected cluster.
Co-authored-by: Rafał Cieślak <rafal.cieslak@goteleport.com>
# Conflicts: # docs/pages/connect-your-client/teleport-connect.mdx
github-actions
Bot
requested review from
alexfornuto,
kimlisa,
ptgott,
r0mant,
ravicious,
xinding33 and
zmb3
public-teleport-github-review-bot
Bot
removed request for
ptgott,
r0mant and
xinding33
ravicious
left a comment
ravicious
left a comment
There was a problem hiding this comment.
Submitted some minor suggestions.
Co-authored-by: Rafał Cieślak <rafal.cieslak@goteleport.com>
* Update docs related to the search bar * Rename "more options menu" to "additional actions menu" * Inform that terminal tabs are bound to the selected cluster * Apply suggestions from code review Co-authored-by: Rafał Cieślak <rafal.cieslak@goteleport.com> * Update screenshots * Crop app screenshots * optimize images * Apply @ravicious suggestions Co-authored-by: Rafał Cieślak <rafal.cieslak@goteleport.com> --------- Co-authored-by: Rafał Cieślak <rafal.cieslak@goteleport.com> Co-authored-by: alexfornuto <alex.fornuto@goteleport.com> (cherry picked from commit ef0cb91)
* Update docs related to the search bar * Rename "more options menu" to "additional actions menu" * Inform that terminal tabs are bound to the selected cluster * Apply suggestions from code review Co-authored-by: Rafał Cieślak <rafal.cieslak@goteleport.com> * Update screenshots * Crop app screenshots * optimize images * Apply @ravicious suggestions Co-authored-by: Rafał Cieślak <rafal.cieslak@goteleport.com> --------- Co-authored-by: Rafał Cieślak <rafal.cieslak@goteleport.com> Co-authored-by: alexfornuto <alex.fornuto@goteleport.com> (cherry picked from commit ef0cb91)
4 participants
Update for docs as now we have the search bar instead of the command bar.
Added:
More Optionsadditional actions button/menu in the UI section