Add ability to overwrite default Teleport MySQL Engine Version#24464
Merged
smallinsky merged 2 commits intomasterfrom Apr 13, 2023
Merged
Add ability to overwrite default Teleport MySQL Engine Version#24464smallinsky merged 2 commits intomasterfrom
smallinsky merged 2 commits intomasterfrom
Conversation
smallinsky
force-pushed
the
smallinsky/proxy_mysql_engine_version
branch
from
20ffa45 to
6a24fef
Compare
github-actions
Bot
added
database-access
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
russjones
approved these changes
Apr 12, 2023
r0mant
approved these changes
Apr 12, 2023
| MySQLPublicAddr apiutils.Strings `yaml:"mysql_public_addr,omitempty"` | ||
|
|
||
| // MySQLEngineVersion allow to overwrite proxy default mysql engine version reported by Teleport proxy. | ||
| MySQLEngineVersion string `yaml:"mysql_engine_version,omitempty"` |
Collaborator
There was a problem hiding this comment.
Very much a nitpick, but IMO "engine" spills out implementation details. How about we call it mysql_server_version?
Contributor
Author
There was a problem hiding this comment.
My main motivation to use MySQL Engine Version was AWS docs where Engine keyword is often used in terms of MySQL Server Version: https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/MySQL.Concepts.VersionMgmt.html
But I don't have strong preference so I will update this.
public-teleport-github-review-bot
Bot
removed the request for review
from GavinFrazar
smallinsky
force-pushed
the
smallinsky/proxy_mysql_engine_version
branch
from
a43b7b7 to
9af6531
Compare
smallinsky
force-pushed
the
smallinsky/proxy_mysql_engine_version
branch
from
9af6531 to
ad3cf9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
mysql_engine_versionproxy settings that allows to overwrite the Teleport MySQL Engine Version:The
mysql_engine_versionapply only for no TLS Routing connections and in case of TLS Routing connections the dynamic MySQL Engine version propagation mechanism by ALPN extension takes precedens over themysql_engine_versionsettings.Why
There is no way to propagate proper MySQL Version when a client connects to the Teleport Proxy without TLS Routing.
Some GUI Client uses different capability to connect to the MySQL Server instance and without propagation correct Engine the GUI connection can fail.
Changing current
DefaultServerVersionversion value will break the old behaviour so themysql_engine_versionwill add ability for manual overriding default Teleport Proxy MySQL Version.TODO: