[v12] Integrations: web API and tctl (#24145)#24458
Merged
marcoandredinis merged 1 commit intobranch/v12from Apr 13, 2023
Merged
[v12] Integrations: web API and tctl (#24145)#24458marcoandredinis merged 1 commit intobranch/v12from
marcoandredinis merged 1 commit intobranch/v12from
Conversation
marcoandredinis
changed the title
zmb3
approved these changes
Apr 12, 2023
marcoandredinis
force-pushed
the
marco/v12/backport_24145
branch
from
b245288 to
308deab
Compare
* Integrations: web api and tclt This PR adds end user interface to manage integrations: `tctl` ``` $ tctl get integrations --config teleport.yaml --format text Name Type Spec ----------- -------- ---------------------------------------------- myawsint aws-oidc RoleARN=arn:aws:iam::123456789012:role/DevTeam mynewawsint aws-oidc RoleARN=arn:aws:iam::123456789012:role/OpsTeam ``` HTTP API ``` $ curl 'https://127.0.0.1.nip.io:3080/v1/webapi/sites/lenix/integrations' { "items": [ { "name": "myawsint", "subKind": "aws-oidc", "awsOIDC": { "roleARN": "arn:aws:iam::123456789012:role/DevTeam" } }, { "name": "mynewawsint", "subKind": "aws-oidc", "awsOIDC": { "roleARN": "arn:aws:iam::123456789012:role/OpsTeam" } } ], "nextKey": "" } ``` * Add explicit type * add awsoidc role arn setter * change serializer * ignore bodyclose linter false positive * check for error before reading * simplify webPack.DoRequest call * fix godoc of WebClientPack.DoRequest * return body and status code only
marcoandredinis
force-pushed
the
marco/v12/backport_24145
branch
from
308deab to
e1714e8
Compare
r0mant
approved these changes
Apr 13, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from kimlisa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #24145