Conversation
gzdunek
commented
Apr 12, 2023
| ref={isActive ? activeItemRef : null} | ||
| role="menuitem" | ||
| $active={isActive} | ||
| active={isActive} |
Contributor
Author
There was a problem hiding this comment.
What's the convention behind adding a dollar sign to props?
https://styled-components.com/docs/api#transient-props
(it does not have any effect here, so I removed it)
gzdunek
force-pushed
the
gzdunek/fix-cluster-filter-when-there-is-one-cluster
branch
from
6cac006 to
9539b00
Compare
ravicious
approved these changes
Apr 14, 2023
| ${props => { | ||
| if (props.active) { | ||
| return css` | ||
| background: ${props => props.theme.colors.levels.elevated}; |
Member
There was a problem hiding this comment.
This is the CSS that ends up being generated. It shouldn't cause problems here but I'd be wary of using this approach in general.
ryanclark
approved these changes
Apr 14, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from kimlisa
gzdunek
deleted the
gzdunek/fix-cluster-filter-when-there-is-one-cluster
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issues that were found in #24190