webapi cleanup#24363
Merged
ibeckermayer merged 12 commits intomasterfrom Apr 28, 2023
Merged
Conversation
Also cleans up the client code to distinguish between terminalSessionPath and activeAndPendingSessionsPath.
zmb3
reviewed
Apr 11, 2023
| // Response body: | ||
| // | ||
| // {"session": {"id": "sid", "terminal_params": {"w": 100, "h": 100}, "parties": [], "login": "bob"}} | ||
| func (h *Handler) siteSessionGet(w http.ResponseWriter, r *http.Request, p httprouter.Params, sctx *SessionContext, site reversetunnel.RemoteSite) (interface{}, error) { |
Contributor
Author
There was a problem hiding this comment.
AFAICT no. But I can use more pairs of eyes as a sanity check.
avatus
approved these changes
Apr 11, 2023
Contributor
avatus
left a comment
avatus
left a comment
There was a problem hiding this comment.
Everything seems to be working fine. I Tested everything session related manually and no hiccups
zmb3
approved these changes
Apr 11, 2023
public-teleport-github-review-bot
Bot
removed request for
kimlisa,
ravicious and
rudream
Base automatically changed from
michaelmyers/is_moderated_sesion_flag
to
master
April 12, 2023 21:42
ibeckermayer
commented
Apr 17, 2023
added 3 commits
April 20, 2023 11:19
…which is no longer used by the frontend
ibeckermayer
force-pushed
the
isaiah/webapi-cleanup
branch
from
a6c5e7e to
6d1343a
Compare
ibeckermayer
pushed a commit
that referenced
this pull request
Apr 28, 2023
* Add isModeratedSession flag to web ssh session * Fix lint * Change to snakecase * Change to moderated * Ensures every Session has a valid Kind field. Also cleans up the client code to distinguish between terminalSessionPath and activeAndPendingSessionsPath. * Entirely removes siteSessionGet which was not being used * removes siteSessionGenerate which was not being used * removes test testing webapi/sites/<cluster-name>/sessions post call, which is no longer used by the frontend * removing unused struct --------- Co-authored-by: Michael Myers <michael.myers@goteleport.com>
ibeckermayer
pushed a commit
that referenced
this pull request
Apr 28, 2023
* Add isModeratedSession flag to web ssh session * Fix lint * Change to snakecase * Change to moderated * Ensures every Session has a valid Kind field. Also cleans up the client code to distinguish between terminalSessionPath and activeAndPendingSessionsPath. * Entirely removes siteSessionGet which was not being used * removes siteSessionGenerate which was not being used * removes test testing webapi/sites/<cluster-name>/sessions post call, which is no longer used by the frontend * removing unused struct --------- Co-authored-by: Michael Myers <michael.myers@goteleport.com>
ibeckermayer
pushed a commit
that referenced
this pull request
Apr 29, 2023
* Add isModeratedSession flag to web ssh session * Fix lint * Change to snakecase * Change to moderated * Ensures every Session has a valid Kind field. Also cleans up the client code to distinguish between terminalSessionPath and activeAndPendingSessionsPath. * Entirely removes siteSessionGet which was not being used * removes siteSessionGenerate which was not being used * removes test testing webapi/sites/<cluster-name>/sessions post call, which is no longer used by the frontend * removing unused struct --------- Co-authored-by: Michael Myers <michael.myers@goteleport.com>
stevenGravy
pushed a commit
that referenced
this pull request
May 1, 2023
* Add isModeratedSession flag to web ssh session * Fix lint * Change to snakecase * Change to moderated * Ensures every Session has a valid Kind field. Also cleans up the client code to distinguish between terminalSessionPath and activeAndPendingSessionsPath. * Entirely removes siteSessionGet which was not being used * removes siteSessionGenerate which was not being used * removes test testing webapi/sites/<cluster-name>/sessions post call, which is no longer used by the frontend * removing unused struct --------- Co-authored-by: Michael Myers <michael.myers@goteleport.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SessionhasKinddefinedto hit all of
/webapi/sites/:site/sessions,/webapi/sites/:site/sessions/:sid/events, and/webapi/sites/:site/sessions/:sid/streamon the backend. The latter two were being hit in theEventProviderwhere we append "/events" or "/stream" tothis.url. Now this has been split intowhich better indicates the different purposes of the paths.
siteSessionsGettoclusterActiveAndPendingSessionsGetsiteSessionGenerateandsiteSessionGet, which were not being used.TODO: change base branch once #24238 is merged