[v11] Fix package names for v1 protos, misc proto changes (#24183)#24266
Merged
espadolini merged 4 commits intobranch/v11from Apr 7, 2023
Merged
[v11] Fix package names for v1 protos, misc proto changes (#24183)#24266espadolini merged 4 commits intobranch/v11from
espadolini merged 4 commits intobranch/v11from
Conversation
This drops the dependency on some random v1.4.3 version of the legacy protoc-gen-go for teleterm protos, using the version in the main go.mod instead.
gzdunek
approved these changes
Apr 7, 2023
rosstimothy
approved these changes
Apr 7, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from codingllama
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #24183 to branch/v11
This includes the naming change for the prehog proto package imports, and a minor regeneration for the teleterm protos, as we're now going to use the legacy protoc-gen-go from the main go.mod rather than some random version picked at the time of backport.
It's possible to change the code generation for the teleterm protos to use the recent protoc-gen-go and split protoc-gen-go-grpc, but it requires some minor code changes and it doesn't seem worth the effort to validate and maintain.