[v12] Fix package names for v1 protos, misc proto changes (#24183)#24263
Merged
espadolini merged 6 commits intobranch/v12from Apr 7, 2023
Merged
[v12] Fix package names for v1 protos, misc proto changes (#24183)#24263espadolini merged 6 commits intobranch/v12from
espadolini merged 6 commits intobranch/v12from
Conversation
This also adds protoc-gen-go-grpc to go.mod
Contributor
Author
|
edit: decided to not bump any version, leaving changes to be purely about the organization of the code rather than functional |
gzdunek
approved these changes
Apr 7, 2023
rosstimothy
approved these changes
Apr 7, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from codingllama
Contributor
|
Thanks for the backports, Edoardo! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #24183 to branch/v12
This includes a regeneration of proto files (in f07defc) with
protoc-gen-gov1.28.1 (matching thegoogle.golang.org/protobufwe're actually using in the repo) but the only change in the generated code was in the comment detailing theprotoc-gen-goversion itself.