Add certificate rotation to teleport openssh join oneshot command #24194
Merged
Add certificate rotation to teleport openssh join oneshot command #24194
Conversation
lxea
force-pushed
the
lxea/adcr-client
branch
2 times, most recently
from
127886c to
c6bb6f5
Compare
russjones
reviewed
Apr 8, 2023
r0mant
reviewed
Apr 11, 2023
Collaborator
r0mant
left a comment
r0mant
left a comment
There was a problem hiding this comment.
First pass, just comments about code organization for now, will do another pass to review the rotation logic in more detail.
lxea
force-pushed
the
lxea/adcr-client
branch
6 times, most recently
from
2d0c8a3 to
c31c72d
Compare
espadolini
reviewed
Apr 24, 2023
r0mant
reviewed
Apr 25, 2023
Collaborator
|
@lxea Is this ready for another review? |
Contributor
Author
Yeah, I think i've gotten most of the comments |
lxea
force-pushed
the
lxea/adcr-client
branch
5 times, most recently
from
45340c3 to
44d52f8
Compare
r0mant
approved these changes
May 16, 2023
Collaborator
r0mant
left a comment
r0mant
left a comment
There was a problem hiding this comment.
lgtm
@lxea Can you please also write an integration test for this? Right now it's very lightly tested so I'm concerned there will be regressions.
We can do it in a follow-up PR. The test would configure/start this new openssh_service and make sure it fetches proper credentials from the cluster, places them where needed and calls the provided restart command.
espadolini
reviewed
May 17, 2023
Comment on lines
155
to
160
Contributor
There was a problem hiding this comment.
This tripped me up really badly, as it's a very common unsafe file manipulation pattern - writeTempAndRename creates files with restrictive 600 permissions already, so this is fine (if unnecessary), but it's not documented to do so. Add some docs to writeTempAndRename to clarify that this is the case.
lxea
force-pushed
the
lxea/adcr-client
branch
2 times, most recently
from
8ca8905 to
c14d42a
Compare
espadolini
reviewed
May 18, 2023
Contributor
espadolini
left a comment
espadolini
left a comment
There was a problem hiding this comment.
LGTM other than figuring out what's up with the shutdown.
added 6 commits
May 22, 2023 11:06
Fix agentless test Resolve comments refactor to use existing rotation/backend resolve comments resolve comments Use a comma separated additional-principals resolve comments resolve some comments resolve comments resolve comments add sshd_test remove openssh from config.Configure just use current time for registerServer rotation resolve comments
espadolini
approved these changes
May 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will have a follow up pr that updates the scripts and tries to execute certificate rotation