Skip to content

Fix TestCheckAccessToRegisteredResource flaky test#24118

Closed
tigrato wants to merge 1 commit intomasterfrom
tigrato/try-fix-modules-race
Closed

Fix TestCheckAccessToRegisteredResource flaky test#24118
tigrato wants to merge 1 commit intomasterfrom
tigrato/try-fix-modules-race

Conversation

@tigrato
Copy link
Copy Markdown
Contributor

@tigrato tigrato commented Apr 5, 2023

When multiple tests run in parallel and one of them replaces the module's features, it affects all the running tests.

A test was changing the modules while running in parallel and it resulted in the flakiness of TestCheckAccessToRegisteredResource because, since #23755, we enforce that the server has the Kubernetes feature enabled in order to upsert the server.

Fixes #24115

When multiple tests run in parallel and one of them replaces the module's features, it affects all the running tests.

A test was changing the modules while running in parallel and it resulted in the flakiness of `TestCheckAccessToRegisteredResource` because, since #23755, we enforce that the server has the Kubernetes feature enabled in order to upsert the server.

Fixes #24115
@tigrato tigrato requested a review from zmb3 April 5, 2023 15:13
@github-actions github-actions Bot requested review from lxea and ravicious April 5, 2023 15:13
@tigrato
Copy link
Copy Markdown
Contributor Author

tigrato commented Apr 5, 2023

Closing in favor of #24117 that also fixes this issue

@tigrato tigrato closed this Apr 5, 2023
@tigrato tigrato mentioned this pull request Apr 5, 2023
@tigrato tigrato deleted the tigrato/try-fix-modules-race branch June 1, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TestCheckAccessToRegisteredResource/has_registered_kube_server flakiness

1 participant