[v12] helm: delete hook-related resource on re-apply#24068
Merged
hugoShaka merged 1 commit intobranch/v12from Apr 4, 2023
Merged
[v12] helm: delete hook-related resource on re-apply#24068hugoShaka merged 1 commit intobranch/v12from
hugoShaka merged 1 commit intobranch/v12from
Conversation
In case of a previously failed deployment this will allow users to attempt directly another chart release without having to delete the jobs. This behaviour is less awkward but might hide previous failures. We can legitimnately expect users to monitor their own failures though.
r0mant
approved these changes
Apr 4, 2023
tigrato
approved these changes
Apr 4, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from webvictim
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #24054 to branch/v12