[v12] Define an explicit device resource as DeviceV1#24024
Merged
codingllama merged 2 commits intobranch/v12from Apr 4, 2023
Merged
[v12] Define an explicit device resource as DeviceV1#24024codingllama merged 2 commits intobranch/v12from
codingllama merged 2 commits intobranch/v12from
Conversation
zmb3
approved these changes
Apr 3, 2023
GavinFrazar
approved these changes
Apr 4, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from nklaassen
* Define the DeviceV1 resource proto * Update generated protos * Move device conversions to API * Test device conversions * Handle nil gracefully * Add license to new files
codingllama
force-pushed
the
codingllama/backport/23901-v12
branch
from
4577cca to
fc07455
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declare an explicit device resource representation as the DeviceV1 proto, under
api/types.
The intent is to make the Terraform integration easier by using the DeviceV1
proto directly.
https://github.com/gravitational/teleport.e/issues/939
Backports #23901 to branch/v12.