Skip to content

[v10] Close auth clients in tctl tests#24016

Closed
zmb3 wants to merge 4 commits intobranch/v10from
bot/backport-24011-branch/v10
Closed

[v10] Close auth clients in tctl tests#24016
zmb3 wants to merge 4 commits intobranch/v10from
bot/backport-24011-branch/v10

Conversation

@zmb3
Copy link
Copy Markdown
Collaborator

@zmb3 zmb3 commented Apr 3, 2023

Backport #24011 to branch/v10

@zmb3
Close auth clients in tctl tests
5edcba5 
Goroutine dumps from failed tests show a large number of goroutines
blocked in GRPC client code. Our tctl tests create auth clients but
only expose them via auth.ClientI, which doesn't have a close method.

Updates #19372 and #24005
@github-actions github-actions Bot added backport size/sm tctl tctl - Teleport admin tool labels Apr 3, 2023
@github-actions github-actions Bot requested review from nklaassen and r0mant April 3, 2023 20:33
@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from nklaassen April 3, 2023 20:55
@zmb3 zmb3 enabled auto-merge April 3, 2023 23:59
@zmb3 zmb3 added this pull request to the merge queue Apr 4, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 4, 2023
@zmb3 zmb3 added this pull request to the merge queue Apr 4, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 4, 2023
@zmb3 zmb3 added this pull request to the merge queue Apr 4, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 4, 2023
@zmb3 zmb3 enabled auto-merge April 4, 2023 22:21
@zmb3 zmb3 added this pull request to the merge queue Apr 4, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 4, 2023
@zmb3 zmb3 added this pull request to the merge queue Apr 4, 2023
@zmb3 zmb3 removed this pull request from the merge queue due to a manual request Apr 4, 2023
@zmb3
Copy link
Copy Markdown
Collaborator Author

zmb3 commented Apr 4, 2023

Sorry v10, you had 5 chances to accept my change.

@zmb3 zmb3 closed this Apr 4, 2023
@zmb3 zmb3 deleted the bot/backport-24011-branch/v10 branch April 26, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@r0mant r0mant r0mant approved these changes

@GavinFrazar GavinFrazar GavinFrazar approved these changes

Assignees

No one assigned

Labels

backport size/sm tctl tctl - Teleport admin tool

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zmb3 @r0mant @GavinFrazar