Skip to content

[v11] Close auth clients in tctl tests#24015

Merged
zmb3 merged 2 commits intobranch/v11from
bot/backport-24011-branch/v11
Apr 4, 2023
Merged

[v11] Close auth clients in tctl tests#24015
zmb3 merged 2 commits intobranch/v11from
bot/backport-24011-branch/v11

Conversation

@zmb3
Copy link
Copy Markdown
Collaborator

@zmb3 zmb3 commented Apr 3, 2023

Backport #24011 to branch/v11

Goroutine dumps from failed tests show a large number of goroutines
blocked in GRPC client code. Our tctl tests create auth clients but
only expose them via auth.ClientI, which doesn't have a close method.

Updates #19372 and #24005
@github-actions github-actions Bot added backport size/sm tctl tctl - Teleport admin tool labels Apr 3, 2023
@github-actions github-actions Bot requested review from nklaassen and r0mant April 3, 2023 20:33
@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from nklaassen April 3, 2023 20:55
@zmb3 zmb3 enabled auto-merge April 3, 2023 23:59
@zmb3 zmb3 added this pull request to the merge queue Apr 4, 2023
Merged via the queue into branch/v11 with commit 0e09b42 Apr 4, 2023
@zmb3 zmb3 deleted the bot/backport-24011-branch/v11 branch April 4, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport size/sm tctl tctl - Teleport admin tool

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants