[v10] Prevent unknown ssh requests from terminating sessions#23906
Merged
rosstimothy merged 2 commits intobranch/v10from Mar 31, 2023
Merged
[v10] Prevent unknown ssh requests from terminating sessions#23906rosstimothy merged 2 commits intobranch/v10from
rosstimothy merged 2 commits intobranch/v10from
Conversation
Instead of returning and aborting a session if an unknown request is received servers now log the warning and continue on.
Because unknown session requests abort sessions instead of getting rejected "envs@goteleport.com" breaks backwards compatability.
r0mant
approved these changes
Mar 31, 2023
zmb3
approved these changes
Mar 31, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from avatus
russjones
approved these changes
Mar 31, 2023
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #23874 to branch/v10
Note: This also reverts part of #23832 because it breaks backwards compatibility due to the server changes in #23874 not existing.