Skip to content

docs: Login Rules Terraform docs#23855

Merged
nklaassen merged 1 commit intomasterfrom
nklaassen/lr-tf-docs
Apr 17, 2023
Merged

docs: Login Rules Terraform docs#23855
nklaassen merged 1 commit intomasterfrom
nklaassen/lr-tf-docs

Conversation

@nklaassen
Copy link
Copy Markdown
Contributor

@nklaassen nklaassen commented Mar 30, 2023

This PR adds docs for configuring Login Rules via the Terraform provider

Issue: #20340

Copy link
Copy Markdown
Contributor

@alexfornuto alexfornuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things I noticed. As discussed, I'll wait for a future release to review further.

Comment thread docs/pages/access-controls/login-rules/terraform.mdx
Comment thread docs/pages/access-controls/login-rules/terraform.mdx Outdated
Comment thread examples/resources/terraform/terraform-login-rules.tf Outdated
@alexfornuto alexfornuto removed their assignment Apr 3, 2023
@nklaassen nklaassen force-pushed the nklaassen/lr-tf-docs branch from a82fc48 to 13b0e1a Compare April 12, 2023 20:40
@nklaassen
Copy link
Copy Markdown
Contributor Author

Hey @alexfornuto I ran through this guide again on 12.1.5, everything is working for me on this version, this is ready for review

@nklaassen nklaassen requested a review from alexfornuto April 13, 2023 15:34
Comment thread docs/pages/access-controls/login-rules/terraform.mdx Outdated
@nklaassen nklaassen force-pushed the nklaassen/lr-tf-docs branch from 13b0e1a to 9aae777 Compare April 14, 2023 22:08
@nklaassen nklaassen added this pull request to the merge queue Apr 17, 2023
Merged via the queue into master with commit 03e361b Apr 17, 2023
@nklaassen nklaassen deleted the nklaassen/lr-tf-docs branch April 17, 2023 16:43
@public-teleport-github-review-bot
Copy link
Copy Markdown

@nklaassen See the table below for backport results.

Branch Result
branch/v12 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants