Skip to content

Order sudoers file lines by role name#23760

Merged
lxea merged 5 commits intomasterfrom
lxea/sudoers-sort-order
Apr 19, 2023
Merged

Order sudoers file lines by role name#23760
lxea merged 5 commits intomasterfrom
lxea/sudoers-sort-order

Conversation

@lxea
Copy link
Copy Markdown
Contributor

@lxea lxea commented Mar 29, 2023

Fix for #23095

Comment thread lib/services/role.go Outdated
@lxea lxea force-pushed the lxea/sudoers-sort-order branch from 822b88a to 8bcbc59 Compare March 30, 2023 09:44
Copy link
Copy Markdown
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lxea Can you include an update to the docs in this PR to add a note saying how sudoer lines will be ordered in our Host User Creation guide?

@lxea lxea force-pushed the lxea/sudoers-sort-order branch from 8bcbc59 to 07a04d1 Compare April 3, 2023 10:29
Comment thread lib/services/role.go Outdated
Comment thread lib/services/role.go Outdated
Comment thread lib/services/role.go Outdated
Comment thread lib/services/role.go Outdated
@lxea lxea force-pushed the lxea/sudoers-sort-order branch from 07a04d1 to 9bdf872 Compare April 3, 2023 12:00
Comment thread lib/services/role_test.go Outdated
Comment thread lib/services/role.go Outdated
@lxea lxea force-pushed the lxea/sudoers-sort-order branch from 268925f to 0dbba8c Compare April 4, 2023 11:39
@lxea lxea added this pull request to the merge queue Apr 19, 2023
Merged via the queue into master with commit 7b8b748 Apr 19, 2023
@lxea lxea deleted the lxea/sudoers-sort-order branch April 19, 2023 09:10
@public-teleport-github-review-bot
Copy link
Copy Markdown

@lxea See the table below for backport results.

Branch Result
branch/v10 Failed
branch/v11 Failed
branch/v12 Create PR
branch/v13 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants