Add initial opsgenie client#23707
Merged
EdwardDowling merged 20 commits intomasterfrom Apr 19, 2023
Merged
Conversation
r0mant
reviewed
Mar 28, 2023
r0mant
requested review from
hugoShaka and
marcoandredinis
and removed request for
mdwn and
timothyb89
rosstimothy
reviewed
Apr 4, 2023
Contributor
marcoandredinis
left a comment
marcoandredinis
left a comment
There was a problem hiding this comment.
Tests are missing
Did we consider using their official go client?
https://docs.opsgenie.com/docs/opsgenie-go-api-v2
hugoShaka
reviewed
Apr 5, 2023
Contributor
marcoandredinis
left a comment
marcoandredinis
left a comment
There was a problem hiding this comment.
Overall LGTM, but left some comments
hugoShaka
reviewed
Apr 17, 2023
hugoShaka
approved these changes
Apr 17, 2023
Contributor
hugoShaka
left a comment
hugoShaka
left a comment
There was a problem hiding this comment.
LGTM once the remaining comments are resolved
marcoandredinis
approved these changes
Apr 18, 2023
marcoandredinis
approved these changes
Apr 18, 2023
r0mant
approved these changes
Apr 19, 2023
EdwardDowling
added a commit
that referenced
this pull request
Jun 21, 2023
* Add initial opsgenie client * Embed opsgenie client config in client and move some helper funcs * Fix mod and sum and call to opsgenie client buildalertbody * Add more godocs and use vendored teleport plugins lib * Rename opsgenie client and config to prevent repetition * Fix struct tag in opsgenie alertbody * Fix misleading comment * Add tests to opsgenie client to check note bodies are formatted * Wrap errs with more descriptive types * Close response bodies and fix error handling * Add missing godoc and fix defer and return order * Add missing godocs to opsgenie types * Change opsgenie client test to not depend on json indent etc * Add example of api url to godoc * Undo unnecessary mod and sum changes * Fix go sum * Move opsgenie client code to integrations/lib * Fix typos
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jun 23, 2023
* Add initial opsgenie client (#23707) * Add initial opsgenie client * Embed opsgenie client config in client and move some helper funcs * Fix mod and sum and call to opsgenie client buildalertbody * Add more godocs and use vendored teleport plugins lib * Rename opsgenie client and config to prevent repetition * Fix struct tag in opsgenie alertbody * Fix misleading comment * Add tests to opsgenie client to check note bodies are formatted * Wrap errs with more descriptive types * Close response bodies and fix error handling * Add missing godoc and fix defer and return order * Add missing godocs to opsgenie types * Change opsgenie client test to not depend on json indent etc * Add example of api url to godoc * Undo unnecessary mod and sum changes * Fix go sum * Move opsgenie client code to integrations/lib * Fix typos * Add opsgenie plugin (#25995)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of 473