Fix IPv6 issues. #2357
Fix IPv6 issues. #2357
Conversation
russjones
force-pushed
the
rjones/ipv6
branch
2 times, most recently
from
fb516de to
3e07393
Compare
russjones
force-pushed
the
rjones/ipv6
branch
from
3e07393 to
43943fd
Compare
| // passed to url.Parse where the host:port is placed within the userinfo | ||
| // part of the URL which only allows alpha numberic plus some punctuation. | ||
| // See the following for details: https://github.com/golang/go/issues/23392. | ||
| escaped := url.QueryEscape(net.JoinHostPort(tc.Host, strconv.Itoa(tc.HostPort))) |
There was a problem hiding this comment.
I would like to encapsulate this logic in the ssh subsystem call library that already deals with parsing @ instead of sprinkling this over the place. Also is escaping is really necessary? can we detect IPV6 address as is?
There was a problem hiding this comment.
The issue isn't the SSH subsystem, but that we pack an IPv6 address into the userinfo of a URL then try and call url.Parse() on it. The userinfo part of a URL can't contain [ and ], see the following ticket: golang/go#23392.
The other approach we can take is do some refactoring around how we store node/cluster info in a utils.NetAddr, however that seemed a more invasive fix.
There was a problem hiding this comment.
Still not sure I understand, where do we treat this address as URL and why do we do it?
|
Closing this for now. See #2124 for more details. |
Purpose
Allow Teleport to set a IPv6 advertise address and allow
tshto connect to IPv6 nodes.Implementation
host:portto allow it to pass userinfo validation.Related Issues
Fixes #2124