Update OpenSSH docs with agentless information#23359
Merged
capnspacehook merged 2 commits intomasterfrom Apr 14, 2023
Merged
Conversation
github-actions
Bot
requested review from
alexfornuto,
ptgott,
r0mant,
xinding33 and
zmb3
ptgott
reviewed
Mar 21, 2023
zmb3
reviewed
Mar 24, 2023
capnspacehook
force-pushed
the
capnspacehook/agentless-docs
branch
from
e143eaf to
ea38583
Compare
r0mant
reviewed
Mar 25, 2023
ptgott
reviewed
Mar 27, 2023
| We've outlined these reasons in [OpenSSH vs Teleport SSH for Servers?](https://goteleport.com/blog/openssh-vs-teleport/) | ||
| `teleport` SSH servers have support for multiple features that are incompatible with OpenSSH: | ||
|
|
||
| - [Dynamically updating node labels from the output of configured commands](../../management/admin/labels.mdx) |
Contributor
There was a problem hiding this comment.
Labels are Teleport specific, so I'm not sure why this would be meaningful to an OpenSSH user. Is the expectation here that OpenSSH users would understand what Teleport labels are?
Contributor
Author
There was a problem hiding this comment.
My thoughts were having an explicit list of what is and isn't supported with agentless nodes would be useful to set user's expectations, what do you think, is that not necessary?
Collaborator
|
@capnspacehook Can you address remaining feedback here so we can re-review and get this merged? |
capnspacehook
force-pushed
the
capnspacehook/agentless-docs
branch
2 times, most recently
from
6ffab62 to
21b4a55
Compare
ptgott
approved these changes
Apr 13, 2023
Contributor
ptgott
left a comment
ptgott
left a comment
There was a problem hiding this comment.
Approved so you're not blocked. Added suggestions that I would recommend incorporating.
public-teleport-github-review-bot
Bot
removed request for
alexfornuto,
jakule and
xinding33
Going forward, agentless nodes are the preferred way to manage OpenSSH nodes, so update the documentation to describe how to add them to a cluster.
capnspacehook
force-pushed
the
capnspacehook/agentless-docs
branch
from
21b4a55 to
2f902af
Compare
Contributor
|
I came across this PR while backporting updates that include this content, specifically this |
Collaborator
|
Only v13. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Going forward, agentless nodes are the preferred way to manage OpenSSH nodes, so update the documentation to describe how to add them to a cluster.
SSH agents are not required to connect to agentless nodes, so remove them from this guide so users don't they they still need them.
Supporting RFD: https://github.com/gravitational/teleport/blob/master/rfd/0098-registered-openssh-nodes.md
Updates #21408.