Skip to content

docs: Add Msft SQL Server client examples and link in sql server guide#23263

Merged
stevenGravy merged 22 commits intomasterfrom
stevenGravy/docs/sqlserverclients
May 18, 2023
Merged

docs: Add Msft SQL Server client examples and link in sql server guide#23263
stevenGravy merged 22 commits intomasterfrom
stevenGravy/docs/sqlserverclients

Conversation

@stevenGravy
Copy link
Copy Markdown
Contributor

Provides examples of connecting using Msft typical clients. Links from the SQL Server guide to SQL Server GUIs.

Comment thread docs/pages/connect-your-client/gui-clients.mdx Outdated
Comment thread docs/pages/connect-your-client/gui-clients.mdx Outdated
Comment thread docs/pages/connect-your-client/gui-clients.mdx Outdated
Comment thread docs/pages/connect-your-client/gui-clients.mdx Outdated
Comment thread docs/pages/database-access/guides/sql-server-ad.mdx Outdated
Comment thread docs/pages/connect-your-client/gui-clients.mdx Outdated
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
Copy link
Copy Markdown
Contributor

@ptgott ptgott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One outstanding comment. Otherwise LGTM

@stevenGravy
Copy link
Copy Markdown
Contributor Author

One outstanding comment. Otherwise LGTM

Please see response. I say leave as is just due to the nature of SQL Server

@stevenGravy stevenGravy changed the title Add Msft SQL Server client examples and link in sql server guide docs: Add Msft SQL Server client examples and link in sql server guide Apr 26, 2023
Copy link
Copy Markdown
Contributor

@alexfornuto alexfornuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed a commit optimizing the images.

Comment thread docs/pages/connect-your-client/gui-clients.mdx Outdated
Comment thread docs/pages/connect-your-client/gui-clients.mdx Outdated
@ptgott ptgott requested review from alexfornuto and zmb3 May 11, 2023 16:05
@stevenGravy
Copy link
Copy Markdown
Contributor Author

I've pushed a commit optimizing the images.

good to approve @alexfornuto ?

Comment thread docs/pages/connect-your-client/gui-clients.mdx Outdated
Comment thread docs/pages/connect-your-client/gui-clients.mdx Outdated
@stevenGravy stevenGravy added this pull request to the merge queue May 18, 2023
@stevenGravy stevenGravy removed this pull request from the merge queue due to a manual request May 18, 2023
@stevenGravy stevenGravy enabled auto-merge May 18, 2023 15:42
@stevenGravy stevenGravy added this pull request to the merge queue May 18, 2023
Merged via the queue into master with commit affe590 May 18, 2023
@stevenGravy stevenGravy deleted the stevenGravy/docs/sqlserverclients branch May 18, 2023 16:06
@public-teleport-github-review-bot
Copy link
Copy Markdown

@stevenGravy See the table below for backport results.

Branch Result
branch/v11 Failed
branch/v12 Failed
branch/v13 Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants