Closed
Conversation
ravicious
force-pushed
the
ravicious/search-resources
branch
from
803064f to
6838a9e
Compare
The performance of the underlying ListResources RPC changes depending on whether the sort field is provided or not. What follows from that is: * A low-level layer such as tshd client should not implement business logic by providing a default sort. * Since the sort field is so important, the callsite should be required to explicitly state it to demonstrate that it took into account the performance implications. * It should be possible to provide no sort.
ravicious
force-pushed
the
ravicious/search-resources
branch
from
6838a9e to
953fef4
Compare
gzdunek
approved these changes
Mar 14, 2023
| resourcesService.searchResources(cluster.uri, search) | ||
| ); | ||
|
|
||
| return (await Promise.all(searchPromises)).flat(); |
| } | ||
|
|
||
| /** | ||
| * searchResources searches for the given list of space-separated keywords across all resource |
Contributor
There was a problem hiding this comment.
Suggested change
| * searchResources searches for the given list of space-separated keywords across all resource | |
| * `searchResources` searches for the given list of space-separated keywords across all resource |
Member
Author
|
Closing in favor of #23980. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gravitational/teleport.e#991 needs to be merged first, otherwise merging this PR is going to break type check in e.
This PR adds a new hook which we can use for the search bar.
Before implementing the hook I had to make a couple of small changes related to how we provide the sort param to
ResourcesService.If you want to check out the hook in action, take a look at
ravicious/spotlight-prototype.