Skip to content

docs: add tip on Kubernetes resources#22977

Merged
stevenGravy merged 9 commits intomasterfrom
stevenGravy/docs/k8spodsaccess
May 15, 2023
Merged

docs: add tip on Kubernetes resources#22977
stevenGravy merged 9 commits intomasterfrom
stevenGravy/docs/k8spodsaccess

Conversation

@stevenGravy
Copy link
Copy Markdown
Contributor

@stevenGravy stevenGravy commented Mar 13, 2023

Some confusion is happening whether k8s resources allows access if k8s users/groups is not set. Added tip for clarification. Just backporting to branch/v12 due to pod resources.

Comment thread docs/pages/kubernetes-access/controls.mdx Outdated
stevenGravy and others added 2 commits March 13, 2023 13:45
Co-authored-by: Alex Fornuto <alex.fornuto@goteleport.com>
Comment thread docs/pages/kubernetes-access/controls.mdx Outdated
Comment thread docs/pages/kubernetes-access/controls.mdx Outdated
@zmb3 zmb3 added inactive Items that have gone stale and are likely to be closed. backport/branch/v13 labels Apr 17, 2023
@alexfornuto alexfornuto removed the inactive Items that have gone stale and are likely to be closed. label Apr 24, 2023
Copy link
Copy Markdown
Contributor

@alexfornuto alexfornuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 with a nit.

Comment thread docs/pages/kubernetes-access/controls.mdx Outdated
Co-authored-by: Alex Fornuto <alex.fornuto@goteleport.com>
Copy link
Copy Markdown
Contributor

@ptgott ptgott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevenGravy Why is this Notice in this particular location? It seems a bit random to me, as this is the section related to the kubernetes_resources field.

@stevenGravy
Copy link
Copy Markdown
Contributor Author

@stevenGravy Why is this Notice in this particular location? It seems a bit random to me, as this is the section related to the kubernetes_resources field.

We've had confusion on what kubernetes_resources was doing. Teleport doesn't change Kubernetes RBAC within a k8s cluster, it just enforces the pod calling through Teleport.

Comment thread docs/pages/kubernetes-access/controls.mdx Outdated
Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>
@stevenGravy
Copy link
Copy Markdown
Contributor Author

Confirmed language update @ptgott

@stevenGravy stevenGravy added this pull request to the merge queue May 15, 2023
@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from r0mant May 15, 2023 15:06
@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from xinding33 May 15, 2023 15:06
@stevenGravy stevenGravy changed the title Add tip on Kubernetes resources docs: add tip on Kubernetes resources May 15, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 15, 2023
@stevenGravy stevenGravy enabled auto-merge May 15, 2023 18:15
@stevenGravy stevenGravy added this pull request to the merge queue May 15, 2023
Merged via the queue into master with commit bf4af6e May 15, 2023
@stevenGravy stevenGravy deleted the stevenGravy/docs/k8spodsaccess branch May 15, 2023 18:42
@public-teleport-github-review-bot
Copy link
Copy Markdown

@stevenGravy See the table below for backport results.

Branch Result
branch/v11 Failed
branch/v12 Create PR
branch/v13 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants