Skip to content

support cross account aws db discovery#22866

Merged
GavinFrazar merged 2 commits intomasterfrom
gavinfrazar/support-cross-account-aws-db-discovery
Apr 10, 2023
Merged

support cross account aws db discovery#22866
GavinFrazar merged 2 commits intomasterfrom
gavinfrazar/support-cross-account-aws-db-discovery

Conversation

@GavinFrazar
Copy link
Copy Markdown
Contributor

@GavinFrazar GavinFrazar commented Mar 10, 2023 •
edited
Loading

Part of a series of PR for this feature issue: #15024 as part of the larger issue tracker: #21872

This PR adds AWS DB discovery with a configured assume_role_arn and external_id via discovery_service or db_service for all AWS protocols.

I have this PR stacked against #23680 so it will automatically change merge base to master after that PR merges.

Example config:

db_service:
  enabled: true
  aws:
    - types: ["rds"]
      regions: ["us-west-1"]
      tags:
        "*": "*"
      assume_role_arn: "arn:aws:iam::123456789012:role/some-role"
      external_id: "someUniqueID"

PRs to follow:

  • teleport db configure bootstrap/teleport db configure aws update
  • docs guide

@GavinFrazar GavinFrazar force-pushed the gavinfrazar/support-cross-account-aws-db-discovery branch 2 times, most recently from 69dbba5 to 5f4e1c8 Compare March 15, 2023 06:46
@GavinFrazar GavinFrazar changed the base branch from master to gavinfrazar/support-cross-account-aws-discovery-protos March 15, 2023 06:46
@GavinFrazar GavinFrazar requested a review from smallinsky March 15, 2023 06:49
@GavinFrazar GavinFrazar force-pushed the gavinfrazar/support-cross-account-aws-discovery-protos branch from 54ac6ed to 8e1f781 Compare March 15, 2023 19:25
Base automatically changed from gavinfrazar/support-cross-account-aws-discovery-protos to master March 15, 2023 23:26
@GavinFrazar GavinFrazar force-pushed the gavinfrazar/support-cross-account-aws-db-discovery branch from 5d3cbfb to 92ed9eb Compare March 29, 2023 20:08
@GavinFrazar GavinFrazar changed the base branch from master to gavinfrazar/support-cross-account-aws-db-access March 29, 2023 20:14
@GavinFrazar GavinFrazar marked this pull request as ready for review March 29, 2023 20:19
@github-actions github-actions Bot added database-access Database access related issues and PRs size/md labels Mar 29, 2023
@github-actions github-actions Bot requested review from codingllama and rudream March 29, 2023 20:19
@codingllama codingllama removed their request for review March 29, 2023 21:08
greedy52
greedy52 approved these changes Mar 31, 2023
View reviewed changes
Comment thread lib/services/database.go Outdated
@GavinFrazar GavinFrazar force-pushed the gavinfrazar/support-cross-account-aws-db-access branch 3 times, most recently from 7e631b1 to 9a34bc7 Compare April 7, 2023 17:57
@GavinFrazar GavinFrazar force-pushed the gavinfrazar/support-cross-account-aws-db-discovery branch from 92ed9eb to e03314b Compare April 7, 2023 18:06
@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from rudream April 7, 2023 18:07
Base automatically changed from gavinfrazar/support-cross-account-aws-db-access to master April 8, 2023 00:16
@GavinFrazar GavinFrazar force-pushed the gavinfrazar/support-cross-account-aws-db-discovery branch from e03314b to c130556 Compare April 8, 2023 01:35
@GavinFrazar GavinFrazar enabled auto-merge April 8, 2023 01:35
@GavinFrazar GavinFrazar added this pull request to the merge queue Apr 8, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 8, 2023
@GavinFrazar GavinFrazar force-pushed the gavinfrazar/support-cross-account-aws-db-discovery branch from c130556 to f7a6a42 Compare April 10, 2023 16:21
@GavinFrazar GavinFrazar enabled auto-merge April 10, 2023 16:21
@GavinFrazar GavinFrazar added this pull request to the merge queue Apr 10, 2023
Merged via the queue into master with commit c42ae4e Apr 10, 2023
@GavinFrazar GavinFrazar deleted the gavinfrazar/support-cross-account-aws-db-discovery branch April 10, 2023 16:52
@tigrato tigrato mentioned this pull request Apr 20, 2023
Merged
tigrato added a commit that referenced this pull request Apr 20, 2023
@tigrato
Extend cross-account discovery for EKS clusters
9adbf99 
This PR adds support for cross-account EKS auto-discovery.

Database Access: #22866
tigrato added a commit that referenced this pull request Apr 27, 2023
@tigrato
Extend cross-account discovery for EKS clusters (#24905)
d6af208 
This PR adds support for cross-account EKS auto-discovery.

Database Access: #22866
github-actions Bot pushed a commit that referenced this pull request Apr 27, 2023
@tigrato
Extend cross-account discovery for EKS clusters
cf57c31 
This PR adds support for cross-account EKS auto-discovery.

Database Access: #22866
tigrato added a commit that referenced this pull request Apr 28, 2023
@tigrato
Extend cross-account discovery for EKS clusters (#25254)
bc840d9 
This PR adds support for cross-account EKS auto-discovery.

Database Access: #22866
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gabrielcorado gabrielcorado gabrielcorado approved these changes

@greedy52 greedy52 greedy52 approved these changes

@smallinsky smallinsky smallinsky approved these changes

Assignees

No one assigned

Labels

database-access Database access related issues and PRs size/md

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GavinFrazar @gabrielcorado @greedy52 @smallinsky