Skip to content

Lock access to mock Firestore Server reqs. #21742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdwn merged 1 commit into from
Feb 13, 2023
Merged

Lock access to mock Firestore Server reqs. #21742

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/backend/firestore/firestorebk_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import (
"os"
"reflect"
"strings"
"sync"
"testing"
"time"
"unsafe"
Expand Down Expand Up @@ -190,6 +191,7 @@ type mockFirestoreServer struct {
// in the future.
firestorepb.FirestoreServer

mu sync.RWMutex
reqs []proto.Message

// If set, Commit returns this error.
Expand All @@ -202,7 +204,10 @@ func (s *mockFirestoreServer) BatchWrite(ctx context.Context, req *firestorepb.B
return nil, fmt.Errorf("x-goog-api-client = %v, expected gl-go key", xg)
}

s.mu.Lock()
s.reqs = append(s.reqs, req)
s.mu.Unlock()

if s.commitErr != nil {
return nil, s.commitErr
}
Expand Down Expand Up @@ -312,12 +317,14 @@ func TestDeleteDocuments(t *testing.T) {
}

var committed int
mockFirestore.mu.RLock()
for _, req := range mockFirestore.reqs {
switch r := req.(type) {
case *firestorepb.BatchWriteRequest:
committed += len(r.Writes)
}
}
mockFirestore.mu.RUnlock()

require.Equal(t, tt.documents, committed)

Expand Down