Merged
Conversation
1.11.2 didn't have support for arm64 so we had to do all this extra stuff in the Dockerfile. 1.11.3 added support for Darwin arm64 and 1.12.4 finally adds support for Linux arm64. This means we can completely remove extra cruft and just install grpc-tools 1.12.4 on all architectures.
ravicious
commented
Feb 8, 2023
| "build-native-deps": "electron-builder install-app-deps", | ||
| "package": "electron-builder build --config electron-builder-config.js --publish never -c.extraMetadata.name=teleport-connect", | ||
| "generate-grpc-shared": "npx -y --target_arch=x64 --package=grpc_tools_node_protoc_ts@5.3.2 --package=grpc-tools@1.11.2 -- grpc_tools_node_protoc -I=src/sharedProcess/api/proto --ts_out=service=grpc-node,mode=grpc-js:src/sharedProcess/api/protogen --grpc_out=grpc_js:src/sharedProcess/api/protogen --js_out=import_style=commonjs,binary:src/sharedProcess/api/protogen src/sharedProcess/api/proto/*.proto" | ||
| "generate-grpc-shared": "npx -y --target_arch=x64 --package=grpc_tools_node_protoc_ts@5.3.2 --package=grpc-tools@1.12.4 -- grpc_tools_node_protoc -I=src/sharedProcess/api/proto --ts_out=service=grpc-node,mode=grpc-js:src/sharedProcess/api/protogen --grpc_out=grpc_js:src/sharedProcess/api/protogen --js_out=import_style=commonjs,binary:src/sharedProcess/api/protogen src/sharedProcess/api/proto/*.proto" |
Member
Author
There was a problem hiding this comment.
This is related to internal protobufs used by Connect. It looks gnarly but we didn't even need to run this command since we added ptyHostService.proto.
Next time we do anything with those protos, we should move them to the proto dir in root as thanks to the webapps merge and #20810 we now have one convenient location for all protos. Actually, I'll add a comment to ptyHostService.proto about it.
ryanclark
approved these changes
Feb 8, 2023
hatched
approved these changes
Feb 8, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from gzdunek
|
@ravicious See the table below for backport results.
|
Member
Author
|
Backports to v10 and v11 need to wait for these PRs: |
ravicious
added a commit
that referenced
this pull request
Feb 9, 2023
1.11.2 didn't have support for arm64 so we had to do all this extra stuff in the Dockerfile. 1.11.3 added support for Darwin arm64 and 1.12.4 finally adds support for Linux arm64. This means we can completely remove extra cruft and just install grpc-tools 1.12.4 on all architectures.
ravicious
added a commit
that referenced
this pull request
Feb 13, 2023
1.11.2 didn't have support for arm64 so we had to do all this extra stuff in the Dockerfile. 1.11.3 added support for Darwin arm64 and 1.12.4 finally adds support for Linux arm64. This means we can completely remove extra cruft and just install grpc-tools 1.12.4 on all architectures.
ravicious
added a commit
that referenced
this pull request
Feb 14, 2023
1.11.2 didn't have support for arm64 so we had to do all this extra stuff in the Dockerfile. 1.11.3 added support for Darwin arm64 and 1.12.4 finally adds support for Linux arm64. This means we can completely remove extra cruft and just install grpc-tools 1.12.4 on all architectures.
ravicious
added a commit
that referenced
this pull request
Feb 14, 2023
1.11.2 didn't have support for arm64 so we had to do all this extra stuff in the Dockerfile. 1.11.3 added support for Darwin arm64 and 1.12.4 finally adds support for Linux arm64. This means we can completely remove extra cruft and just install grpc-tools 1.12.4 on all architectures.
avatus
pushed a commit
that referenced
this pull request
Mar 3, 2023
* Update JS grpc-tools to 1.12.4 1.11.2 didn't have support for arm64 so we had to do all this extra stuff in the Dockerfile. 1.11.3 added support for Darwin arm64 and 1.12.4 finally adds support for Linux arm64. This means we can completely remove extra cruft and just install grpc-tools 1.12.4 on all architectures. * Add comment to ptyHostService.proto
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.11.2 didn't have support for arm64 so we had to do all this extra stuff in the Dockerfile.
1.11.3 added support for Darwin arm64 and 1.12.4 finally adds support for Linux arm64. This means we can completely remove extra cruft and just install grpc-tools 1.12.4 on all architectures.